Add modem tests to travis. #94
Conversation
| # Need sudo for trusty. | ||
| sudo: required | ||
| # Trusty gives us GCC 4.8 which supports c++11. | ||
| dist: trusty |
There was a problem hiding this comment.
so we should be able to get modern gcc w/o sudo with addons: apt: see http://genbattle.bitbucket.org/blog/2016/01/17/c++-travis-ci/
There was a problem hiding this comment.
Ya I was playing with that when I last worked on this. I couldn't seem to get it to pass validation (http://lint.travis-ci.org/) so I was trying to figure out if I did something wrong. I will just try committing it to this PR and see if it works.
This way works but it takes longer to schedule it seems.
This broke the unit tests.
|
The core of this PR is ready, unfortunately the tests are failing due to the "ERROR: this mock object (used in test GetCommandTest.gets) should be deleted but never is. Its address is @0x99ea60" issues I was ignoring before. I am working on fixing those before merging this. |
|
This PR is ready. |
| install: | ||
| - if [ "$CXX" = "g++" ]; then export CXX="g++-4.8" CC="gcc-4.8"; fi |
There was a problem hiding this comment.
what's nice with keeping g++ in the env is that we can try with different version, I guess we can introduce it later when we actually text multiple version :)
|
LGTM |
Not sure if this is ready yet, only way I know to test is have it run against a PR.